Skip to content

feat: HIP-1137#2654

Draft
manishdait wants to merge 27 commits intohiero-ledger:mainfrom
manishdait:feat/hip-1137
Draft

feat: HIP-1137#2654
manishdait wants to merge 27 commits intohiero-ledger:mainfrom
manishdait:feat/hip-1137

Conversation

@manishdait
Copy link
Copy Markdown
Contributor

@manishdait manishdait commented Mar 13, 2026

Description:
This PR introduce HIP 1137

Related issue(s):

Fixes #2644

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 6, 2026 •
edited
Loading

Not up to standards ⛔

🔴 Issues 2 medium

Alerts:
⚠ 2 issues (≤ 0 issues of at least minor severity)

Results:
2 new issues

Category Results
BestPractice 1 medium
Complexity 1 medium

View in Codacy

🟢 Metrics 372 complexity

Metric Results
Complexity 372

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@manishdait
Copy link
Copy Markdown
Contributor Author

manishdait commented Apr 8, 2026 •
edited
Loading

Hi @mustafauzunn, Is there any update on the Mirrornode Rest endpoint for registerdNode

@mustafauzunn
Copy link
Copy Markdown
Contributor

mustafauzunn commented Apr 8, 2026

Hi @manishdait , you can follow this EPIC hiero-ledger/hiero-mirror-node#12932
The endpoint task is in progress

@mustafauzunn
Copy link
Copy Markdown
Contributor

mustafauzunn commented Apr 15, 2026

Hi @manishdait
we have some changes to the hip. Please check hiero-ledger/sdk-collaboration-hub#167

@manishdait
Copy link
Copy Markdown
Contributor Author

manishdait commented Apr 15, 2026

@mustafauzunn, Thanks for sharing

@mustafauzunn
Copy link
Copy Markdown
Contributor

mustafauzunn commented Apr 16, 2026

Hi @manishdait
It seems like mirror node changes are ready hiero-ledger/hiero-mirror-node#12932

@manishdait
Copy link
Copy Markdown
Contributor Author

manishdait commented Apr 24, 2026

Hi @mustafauzunn, I updated the hieroVersion in the solo-action to 0.73.0 for testing, but the Hook-related e2e tests are failing. I try to run them on my local solo setup and on testnet but the Hook related issues still fails with HOOK_NOT_ENABLED status. At the moment, I’m not sure whether this is caused by the hieroVersion change or an issue with the SDK’s hook tests.

Here is the log for AccountCreateTransactionHooksIntegrationTest integration test, I run using the testnet

> Task :sdk:testIntegration
  com.hedera.hashgraph.sdk.test.integration.AccountCreateTransactionHooksIntegrationTest ✘ Given AccountCreateTransaction with basic EVM hook, when executed, then receipt status is SUCCESS (15.2s)
                                                                                                                                                                                                                             
    com.hedera.hashgraph.sdk.PrecheckStatusException: Hedera transaction `0.0.6105114@1777016676.272000651` failed pre-check with the status `HOOKS_NOT_ENABLED`
        at app/com.hedera.hashgraph.sdk.test.integration@2.70.0/com.hedera.hashgraph.sdk.test.integration.AccountCreateTransactionHooksIntegrationTest.accountCreateWithBasicLambdaHookSucceeds(AccountCreateTransactionHooksIntegrationTest.java:39)
                                                                                                                                                                                                                             

  0 passing (19.2s)
  1 pending                                                                                                                                                                                                                  
  1 failing                                                                                                                                                                                                                  


2 tests completed, 1 failed, 1 skipped

> Task :sdk:testIntegration FAILED

FAILURE: Build failed with an exception.

@mustafauzunn
Copy link
Copy Markdown
Contributor

mustafauzunn commented Apr 27, 2026

Hi @manishdait you can disable hooks tests for now. Hooks are disabled on 0.73.0

manishdait added 14 commits April 30, 2026 17:39
@manishdait
feat: added the protos for hip-1137
2dc3cb0 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: added the new classed
1b416c7 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: added new fields to existing class
e92b6f1 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: added class structure for registeredNodeAdressBook query
8157151 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: added e2e test for the registeredNodeTx
ba6699e 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: change acess modifier
8f03dc2 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: fix tx signing
39a86c3 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: add initial example
7c2eaa0 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: added clearServiceEndpoint method
cb551a6 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: completed example
52f47a9 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: updated the proto to use the fix protobuf
e0e2809 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: updated the hip impl for protobuf changes
3a30c6d 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: neat pick
4f780ce 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: spotless
0bba294 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait added 12 commits April 30, 2026 17:40
@manishdait
feat: added initial registeredNode query
bbbd65d 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: added unit test for initial query
d3a7b76 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: added docs
52bda95 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
feat: added missing status enum
16d735e 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: improve the structure
0ea81f3 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: refactor code for parsing json
cbd0059 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: added more test for the create tx
88d67a5 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: fix to proto to include mirror and rpc ep
f7faf94 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: expand test for delete node
04df3f8 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: added test for the registered address book query
bf1dc22 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: updated mirrornode version
48215d0 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore: apply spotless
a3f1785 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
@manishdait
chore fix rebase
aa110b1 
Signed-off-by: Manish Dait <daitmanish88@gmail.com>
manishdait
manishdait commented May 1, 2026
View reviewed changes
Comment thread sdk/src/main/java/com/hedera/hashgraph/sdk/NodeCreateTransaction.java
*/
public NodeCreateTransaction addAssociatedRegisteredNode(long associatedRegisteredNode) {
requireNotFrozen();
if (associatedRegisteredNodes.size() >= 20) {
Copy link
Copy Markdown
Contributor Author

@manishdait manishdait May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mustafauzunn should we remove this check and let it handle by the consensus node to throw the PrecheckError with MAX_REGISTERED_NODES_EXCEEDED. also similar with other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mustafauzunn mustafauzunn mustafauzunn left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@manishdait manishdait

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement HIP-1137 — Block Node discoverability via on-chain registry

2 participants

@manishdait @mustafauzunn